git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Improve git-help--browse browser support under OS X

From
Jay Soffian <jaysoffian+git@gmail.com>
Date
Feb 10, 2008, 02:15 UTC
Message-ID
<76718490802091815s45c19113t938f5257aad3f46c@mail.gmail.com>
In-Reply-To
<20080209202020.GD30368@dpotapov.dyndns.org>
On Feb 9, 2008 3:20 PM, Dmitry Potapov <dpotapov@gmail.com> wrote:
Show 13 quoted lines
> On Fri, Feb 08, 2008 at 04:23:14PM -0500, jaysoffian+git@gmail.com wrote:
> > /usr/bin/open <document> is used under OS X to open a document just as if the
> > user had double-clicked on the file's icon. In other words, this will open HTML
> > files with the user's default browser. Note however that whether the document
> > opens in a new window, or in a new tab depends upon the browser configuration.
>
> This is OS X specific, so the change should be made in such a way that it
> will not affect anyone else. Because people on other platforms may have
> "open" to do different things. For example, on Linux, the "open" command
> is used to open a new virtual terminal. At the same time, other systems
> may have their own ways to start the default browser. For instance, on
> Debian based systems, it is usually x-www-browser for X and www-browser
> for terminal.

I guess I'm confused by the criticism as I thought that's what I did. "open" is only added to the list of browsers to try if the SECURITYSESSIONID environment variable is set (indicating an OS X GUI login environment). I don't see how the change I made could adversely impact the users of other systems.

j.
Previous: Dmitry PotapovNext: Dmitry Potapov
Message 3 of 17 in “Improve git-help--browse browser support under OS X”
  1. Improve git-help--browse browser support under OS Xjaysoffian+git@gmail.com, Feb 8, 2008
  2. Dmitry PotapovFeb 9, 2008
  3. Jay SoffianFeb 10, 2008
  4. Dmitry PotapovFeb 10, 2008
  5. Christian CouderFeb 10, 2008
  6. Jay SoffianFeb 11, 2008
  7. Christian CouderFeb 11, 2008
  8. Jay SoffianFeb 11, 2008
  9. git-web--browse: improve browser support under OS Xjaysoffian+git@gmail.com, Feb 11, 2008
  10. Junio C HamanoFeb 11, 2008
  11. Jay SoffianFeb 11, 2008
  12. Jay SoffianFeb 12, 2008
  13. Christian CouderFeb 13, 2008
  14. Junio C HamanoFeb 13, 2008
  15. Pieter de BieFeb 13, 2008
  16. Jay SoffianFeb 14, 2008
  17. Christian CouderFeb 14, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.