Re: [PATCH] git-web--browse: improve browser support under OS X
- From
Jay Soffian <jaysoffian+git@gmail.com>
- Date
- Feb 11, 2008, 14:15 UTC
- Message-ID
- <76718490802110615j3017e17awcae2a04087984f0d@mail.gmail.com>
- In-Reply-To
- <7vve4wb3h7.fsf@gitster.siamese.dyndns.org>
On Feb 10, 2008 10:01 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 5 quoted lines
> Because we preprocess git-web--browse.sh to create the final > git-web--browse to be installed, something like "open" that is > not a user but a platform preference might be better done as a > build-time thing, instead of forcing everybody to spawn "uname", > perhaps like this?
Seems like overkill (over the original patch), but honestly, I'm happy with whatever solution deemed appropriate, just as long as I can use my native browser on OS X. :-)
> Also I wonder why the check for SECURITYSESSIONID your original > had is not good enough for this Mac specific customization?
Well, I thought it was. I was just responding to feedback. I don't have enough experience with the git project to have much of an opinion either way.
Anyway, thanks for the pointers.
j.