Re: [PATCH] git-web--browse: improve browser support under OS X

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 13, 2008, 22:14 UTC
Message-ID: <7vk5l8o65o.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <200802130755.20884.chriscool@tuxfamily.org>

Christian Couder <chriscool@tuxfamily.org> writes:

Show 11 quoted lines

> Le mardi 12 février 2008, Jay Soffian a écrit :
>> On Feb 10, 2008 10:01 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> > Also I wonder why the check for SECURITYSESSIONID your original
>> > had is not good enough for this Mac specific customization?
>>
>> Christian,
>>
>> Any thoughts on Junio's patch vs the original?
>
> I think the original was good and Junio's patch is a good improvement on top 
> of yours.

I think the original that only checked SECURITYSESSIONID was short, sweet and inexpensive.

Unless somebody comes up with a good reason that the environment check for SECURITYSESSIONID would misidentify (my understanding is that it is a MacOS specific hack^Wenvironment variable and nobody else would have it, but I haven't found authoritative source), I think the original from Jay is good and I can apply it to 'master'.

I very much had trouble with the $(uname -s) thing which unconditionally penalized everybody else, and that was the primary reason I suggested an alternative to make it cheaper.