Re: [PATCH] Improve git-help--browse browser support under OS X

From: Jay Soffian <jaysoffian+git@gmail.com>
Date: Feb 11, 2008, 02:10 UTC
Message-ID: <76718490802101810u74f86927hefacac162c69f697@mail.gmail.com>
In-Reply-To: <20080210124336.GH30368@dpotapov.dyndns.org>

On Feb 10, 2008 7:43 AM, Dmitry Potapov <dpotapov@gmail.com> wrote:

Show 15 quoted lines

> On Sat, Feb 09, 2008 at 09:15:30PM -0500, Jay Soffian wrote:
>
> Would not be better to use uname instead like this
>
>   if test "$(uname -s)" == "Darwin"; then
>     ...
> or in addition to SECURITYSESSIONID:
>
>   if test -n "$SECURITYSESSIONID" -a "$(uname -s)" == "Darwin"; then
>     ...
> ?
>
> I think it would be more reliable and more importantly it makes the
> code easier to understand, because it is clear now for everyone that
> this is OS X specific.

Sure.

> BTW, should not it be mentioned in the documentation? Probably, in
> the list of supported web browsers in git-help.txt.

Yep, will do.

j.