Re: [PATCH] Improve git-help--browse browser support under OS X

From: Dmitry Potapov <dpotapov@gmail.com>
Date: Feb 10, 2008, 12:43 UTC
Message-ID: <20080210124336.GH30368@dpotapov.dyndns.org>
In-Reply-To: <76718490802091815s45c19113t938f5257aad3f46c@mail.gmail.com>

On Sat, Feb 09, 2008 at 09:15:30PM -0500, Jay Soffian wrote:

Show 6 quoted lines

> 
> I guess I'm confused by the criticism as I thought that's what I did.
> "open" is only added to the list of browsers to try if the
> SECURITYSESSIONID environment variable is set (indicating an OS X GUI
> login environment). I don't see how the change I made could adversely
> impact the users of other systems.

Would not be better to use uname instead like this

  if test "$(uname -s)" == "Darwin"; then
    ...
or in addition to SECURITYSESSIONID:

  if test -n "$SECURITYSESSIONID" -a "$(uname -s)" == "Darwin"; then
    ...
?

I think it would be more reliable and more importantly it makes the code easier to understand, because it is clear now for everyone that this is OS X specific.

BTW, should not it be mentioned in the documentation? Probably, in the list of supported web browsers in git-help.txt.

Dmitry