From: Jay Soffian <jaysoffian+git@gmail.com>
Date: Sun, 10 Feb 2008 02:15:30 GMT
Subject: Re: [PATCH] Improve git-help--browse browser support under OS X
Message-ID: <76718490802091815s45c19113t938f5257aad3f46c@mail.gmail.com>
In-Reply-To: <20080209202020.GD30368@dpotapov.dyndns.org>

On Feb 9, 2008 3:20 PM, Dmitry Potapov <dpotapov@gmail.com> wrote:
> On Fri, Feb 08, 2008 at 04:23:14PM -0500, jaysoffian+git@gmail.com wrote:
> > /usr/bin/open <document> is used under OS X to open a document just as if the
> > user had double-clicked on the file's icon. In other words, this will open HTML
> > files with the user's default browser. Note however that whether the document
> > opens in a new window, or in a new tab depends upon the browser configuration.
>
> This is OS X specific, so the change should be made in such a way that it
> will not affect anyone else. Because people on other platforms may have
> "open" to do different things. For example, on Linux, the "open" command
> is used to open a new virtual terminal. At the same time, other systems
> may have their own ways to start the default browser. For instance, on
> Debian based systems, it is usually x-www-browser for X and www-browser
> for terminal.

I guess I'm confused by the criticism as I thought that's what I did.
"open" is only added to the list of browsers to try if the
SECURITYSESSIONID environment variable is set (indicating an OS X GUI
login environment). I don't see how the change I made could adversely
impact the users of other systems.

j.