Re: [PATCH 3/4] format-patch: new --resend option for adding "RESEND" to patch subjects

From: Dragan Simic <dsimic@manjaro.org>
Date: Apr 17, 2024, 07:16 UTC
Message-ID: <60927cebd6128ee490c826d010e52da2@manjaro.org>
In-Reply-To: <f054eb17-2eea-40f5-b201-92432aa0ad9c@app.fastmail.com>

On 2024-04-17 08:43, Kristoffer Haugsbakk wrote:

Show 10 quoted lines

> On Wed, Apr 17, 2024, at 08:36, Dragan Simic wrote:
>> It also doesn't use imperative mood.
> 
> The sentence describes what the option does (usage). It doesn’t explain
> what the commit message does. In context:
> 
>     Teach format-patch about --resend
> 
>     --resend adds "RESEND" to the subject prefix (producing "PATCH
>     RESEND" by default).

Frankly, I don't like the "teach abc xyz" wording very much. It isn't some intelligent being to be taught something new. :) That's just my personal preference, of course.

Furthermore, starting a sentence with "--resend" isn't very good. Please note that you're still using parenthesis, for which I already explained why they should be avoided.