git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] git-gui: silence install recipes under "make -s"

From
Johannes Sixt <j6t@kdbg.org>
Date
Jun 3, 2026, 21:38 UTC
Message-ID
<5c0a5305-00c5-403f-a007-f5f3c163f8d1@kdbg.org>
In-Reply-To
<pull.2318.v2.git.git.1780510415838.gitgitgadget@gmail.com>
Am 03.06.26 um 20:13 schrieb Harald Nordgren via GitGitGadget:
Show 14 quoted lines
> From: Harald Nordgren <haraldnordgren@gmail.com>
> 
> Several install and uninstall recipes embed "echo" calls that fire as
> part of the recipe itself, so the install banners (DEST, INSTALL,
> LINK, REMOVE) were visible whenever the variables expand non-empty.
> 
> Guard the whole "ifndef V" block on "-s" so the loud variants are
> selected only when "-s" is absent and V=1 is unset.
> 
> Signed-off-by: Harald Nordgren <harald.nordgren@kostdoktorn.se>
> ---
>     git-gui: silence install recipes under "make -s"
>     
>      * Clarified commit message.

I appreciate that you made it more suitable to be used outside of the Git repository, but it still does not explain why the change from ifeq to ifneq is not sufficient to negate the condition.

In fact, the old version of the condition never worked as intended. The parameters of findstring are in the order needle,haystack. The arguments are -,s for normal `make` and -s,s for `make -s`. In no case is the needle found in the haystack. The new version is correct. This is worth to be mentioned.

> +ifneq ($(findstring s,$(firstword -$(MAKEFLAGS))),s)
> -ifeq ($(findstring $(firstword -$(MAKEFLAGS)),s),s)
-- Hannes
Previous: Harald Nordgren via GitGitGadgetNext: Harald Nordgren via GitGitGadget
Message 5 of 14 in “git-gui: silence install recipes under "make -s"”
  1. git-gui: silence install recipes under "make -s"Harald Nordgren via GitGitGadget, Jun 3, 2026
  2. Johannes SixtJun 3, 2026
  3. Harald NordgrenJun 3, 2026
  4. git-gui: silence install recipes under "make -s"Harald Nordgren via GitGitGadget, Jun 3, 2026
  5. Johannes SixtJun 3, 2026
  6. git-gui: silence install recipes under "make -s"Harald Nordgren via GitGitGadget, Jun 4, 2026
  7. Johannes SixtJun 6, 2026
  8. git-gui: silence install recipes under "make -s"Harald Nordgren via GitGitGadget, Jun 6, 2026
  9. Johannes SixtJun 6, 2026
  10. Harald NordgrenJun 10, 2026
  11. Johannes SixtJun 11, 2026
  12. Harald NordgrenJun 11, 2026
  13. Kristoffer HaugsbakkJun 11, 2026
  14. Harald NordgrenJun 11, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.