Re: [PATCH] git-gui: silence install recipes under "make -s"
- From
Johannes Sixt <j6t@kdbg.org>
- Date
- Jun 3, 2026, 12:58 UTC
- Message-ID
- <010c001d-e241-475d-99ba-f60f71d3365f@kdbg.org>
- In-Reply-To
- <pull.2318.git.git.1780477489662.gitgitgadget@gmail.com>
Am 03.06.26 um 11:04 schrieb Harald Nordgren via GitGitGadget:
Show 6 quoted lines
> From: Harald Nordgren <haraldnordgren@gmail.com> > > The split install/uninstall recipes embed "echo" calls that fire > even under "make -s", so install still prints "DEST /path" and > "INSTALL 644 about.tcl" banners. The existing "-s" block only > clears QUIET_GEN.
Good catch.
> Wrap the whole "ifndef V" block in the canonical "-s" guard from > shared.mak, and drop the now-redundant narrow block.
Can we please mention shared.mak in a way that doesn't assume that this patch was made in the Git repository?
Show 9 quoted lines
> +ifneq ($(findstring s,$(firstword -$(MAKEFLAGS))),s) > ifndef V > QUIET = @ > QUIET_GEN = $(QUIET)echo ' ' GEN '$@' && > @@ -89,6 +90,7 @@ ifndef V > REMOVE_F0 = dst= > REMOVE_F1 = && echo ' ' REMOVE `basename "$$dst"` && $(RM_RF) "$$dst" > endif > +endif
> -ifeq ($(findstring $(firstword -$(MAKEFLAGS)),s),s)
I would have expected that the old and the new condition expressions only differ in the ifeq vs. ifneq, but they are different in more than that. Assuming that the new expression is correct, was the old one incorrect?
> -QUIET_GEN = > -endif
-- Hannes