From: Johannes Sixt Date: Wed, 03 Jun 2026 21:38:47 GMT Subject: Re: [PATCH v2] git-gui: silence install recipes under "make -s" Message-ID: <5c0a5305-00c5-403f-a007-f5f3c163f8d1@kdbg.org> In-Reply-To: Am 03.06.26 um 20:13 schrieb Harald Nordgren via GitGitGadget: > From: Harald Nordgren > > Several install and uninstall recipes embed "echo" calls that fire as > part of the recipe itself, so the install banners (DEST, INSTALL, > LINK, REMOVE) were visible whenever the variables expand non-empty. > > Guard the whole "ifndef V" block on "-s" so the loud variants are > selected only when "-s" is absent and V=1 is unset. > > Signed-off-by: Harald Nordgren > --- > git-gui: silence install recipes under "make -s" > > * Clarified commit message. I appreciate that you made it more suitable to be used outside of the Git repository, but it still does not explain why the change from ifeq to ifneq is not sufficient to negate the condition. In fact, the old version of the condition never worked as intended. The parameters of findstring are in the order needle,haystack. The arguments are -,s for normal `make` and -s,s for `make -s`. In no case is the needle found in the haystack. The new version is correct. This is worth to be mentioned. > +ifneq ($(findstring s,$(firstword -$(MAKEFLAGS))),s) > -ifeq ($(findstring $(firstword -$(MAKEFLAGS)),s),s) -- Hannes