From: Harald Nordgren <haraldnordgren@gmail.com>

The split install/uninstall recipes embed "echo" calls that fire even under "make -s", so install still prints "DEST /path" and "INSTALL 644 about.tcl" banners. The existing "-s" block only clears QUIET_GEN.

Wrap the whole "ifndef V" block in the canonical "-s" guard from shared.mak, and drop the now-redundant narrow block.

Signed-off-by: Harald Nordgren <harald.nordgren@kostdoktorn.se>
---
    git-gui: silence install recipes under "make -s"

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2318%2FHaraldNordgren%2Fgit-gui-respect-silent-flag-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2318/HaraldNordgren/git-gui-respect-silent-flag-v1
Pull-Request: https://github.com/git/git/pull/2318

 git-gui/Makefile | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Am 03.06.26 um 11:04 schrieb Harald Nordgren via GitGitGadget:

Good catch.

Can we please mention shared.mak in a way that doesn't assume that this patch was made in the Git repository?

I would have expected that the old and the new condition expressions only differ in the ifeq vs. ifneq, but they are different in more than that. Assuming that the new expression is correct, was the old one incorrect?

-- Hannes

Good point!

Yeah, the old format doesn't seem to work when I use that with ifneq. So I took this other format that is also used twice in shared.mak (lines 40 and 46).

Harald

From: Harald Nordgren <haraldnordgren@gmail.com>

Several install and uninstall recipes embed "echo" calls that fire as part of the recipe itself, so the install banners (DEST, INSTALL, LINK, REMOVE) were visible whenever the variables expand non-empty.

Guard the whole "ifndef V" block on "-s" so the loud variants are selected only when "-s" is absent and V=1 is unset.

Signed-off-by: Harald Nordgren <harald.nordgren@kostdoktorn.se>
---
    git-gui: silence install recipes under "make -s"
    
     * Clarified commit message.

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2318%2FHaraldNordgren%2Fgit-gui-respect-silent-flag-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2318/HaraldNordgren/git-gui-respect-silent-flag-v2
Pull-Request: https://github.com/git/git/pull/2318

Range-diff vs v1:

 1:  b9f2b16a8d ! 1:  4e4029c8e8 git-gui: silence install recipes under "make -s"
     @@ Metadata
       ## Commit message ##
          git-gui: silence install recipes under "make -s"
      
     -    The split install/uninstall recipes embed "echo" calls that fire
     -    even under "make -s", so install still prints "DEST /path" and
     -    "INSTALL 644 about.tcl" banners. The existing "-s" block only
     -    clears QUIET_GEN.
     +    Several install and uninstall recipes embed "echo" calls that fire as
     +    part of the recipe itself, so the install banners (DEST, INSTALL,
     +    LINK, REMOVE) were visible whenever the variables expand non-empty.
      
     -    Wrap the whole "ifndef V" block in the canonical "-s" guard from
     -    shared.mak, and drop the now-redundant narrow block.
     +    Guard the whole "ifndef V" block on "-s" so the loud variants are
     +    selected only when "-s" is absent and V=1 is unset.
      
          Signed-off-by: Harald Nordgren <harald.nordgren@kostdoktorn.se>
      

 git-gui/Makefile | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Am 03.06.26 um 20:13 schrieb Harald Nordgren via GitGitGadget:

I appreciate that you made it more suitable to be used outside of the Git repository, but it still does not explain why the change from ifeq to ifneq is not sufficient to negate the condition.

In fact, the old version of the condition never worked as intended. The parameters of findstring are in the order needle,haystack. The arguments are -,s for normal `make` and -s,s for `make -s`. In no case is the needle found in the haystack. The new version is correct. This is worth to be mentioned.

-- Hannes

From: Harald Nordgren <haraldnordgren@gmail.com>

Several install and uninstall recipes embed "echo" calls that fire as part of the recipe itself, so the install banners (DEST, INSTALL, LINK, REMOVE) were visible whenever the variables expand non-empty.

Guard the whole "ifndef V" block on "-s" so the loud variants are selected only when "-s" is absent and V=1 is unset. The existing "-s" check also had its findstring arguments in the wrong order (needle "-s" never fit in haystack "s"), so swap them while moving the check to wrap the block.

Signed-off-by: Harald Nordgren <harald.nordgren@kostdoktorn.se>
---
    git-gui: silence install recipes under "make -s"
    
    Added sentences to the commit message noting that the old findstring arg
    order was broken (needle never fit haystack).

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2318%2FHaraldNordgren%2Fgit-gui-respect-silent-flag-v3
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2318/HaraldNordgren/git-gui-respect-silent-flag-v3
Pull-Request: https://github.com/git/git/pull/2318

Range-diff vs v2:

 1:  4e4029c8e8 ! 1:  1375fdc1aa git-gui: silence install recipes under "make -s"
     @@ Commit message
          LINK, REMOVE) were visible whenever the variables expand non-empty.
      
          Guard the whole "ifndef V" block on "-s" so the loud variants are
     -    selected only when "-s" is absent and V=1 is unset.
     +    selected only when "-s" is absent and V=1 is unset. The existing
     +    "-s" check also had its findstring arguments in the wrong order
     +    (needle "-s" never fit in haystack "s"), so swap them while moving
     +    the check to wrap the block.
      
          Signed-off-by: Harald Nordgren <harald.nordgren@kostdoktorn.se>
      

 git-gui/Makefile | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Am 04.06.26 um 08:48 schrieb Harald Nordgren via GitGitGadget:

The new text looks good. However, the email addresses of author and signer-off are different. They should be the same. I notice that you use the gmail address in both places in other patch submissions, so I can use that if you agree (and you don't need to send another round).

-- Hannes

From: Harald Nordgren <haraldnordgren@gmail.com>

Several install and uninstall recipes embed "echo" calls that fire as part of the recipe itself, so the install banners (DEST, INSTALL, LINK, REMOVE) were visible whenever the variables expand non-empty.

Guard the whole "ifndef V" block on "-s" so the loud variants are selected only when "-s" is absent and V=1 is unset. The existing "-s" check also had its findstring arguments in the wrong order (needle "-s" never fit in haystack "s"), so swap them while moving the check to wrap the block.

Signed-off-by: Harald Nordgren <haraldnordgren@gmail.com>
---
    git-gui: silence install recipes under "make -s"
    
    Change sign-off email from work email to correct personal email.

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2318%2FHaraldNordgren%2Fgit-gui-respect-silent-flag-v4
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2318/HaraldNordgren/git-gui-respect-silent-flag-v4
Pull-Request: https://github.com/git/git/pull/2318

Range-diff vs v3:

 1:  1375fdc1aa ! 1:  27d9fcf26b git-gui: silence install recipes under "make -s"
     @@ Commit message
          (needle "-s" never fit in haystack "s"), so swap them while moving
          the check to wrap the block.
      
     -    Signed-off-by: Harald Nordgren <harald.nordgren@kostdoktorn.se>
     +    Signed-off-by: Harald Nordgren <haraldnordgren@gmail.com>
      
       ## git-gui/Makefile ##
      @@ git-gui/Makefile: REMOVE_F0  = $(RM_RF) # space is required here

 git-gui/Makefile | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Thanks, queued.

-- Hannes

On Sat, Jun 6, 2026 at 1:47 PM Johannes Sixt <j6t@kdbg.org> wrote:

Hi!

Thanks for the help!

What does it mean for it to be queued here, should I expect it to show up on seen or next?

Harald

Am 10.06.26 um 15:19 schrieb Harald Nordgren:

It means that I'll arrange that it will appear in the next Git release. Until then you can find the commit in https://github.com/j6t/git-gui/tree/hn/silence-make-s .

-- Hannes

On Thu, Jun 11, 2026 at 7:37 AM Johannes Sixt <j6t@kdbg.org> wrote:

Thanks! So does that mean that 'seen' and 'next' are branches that are added to only by Junio Hamano?

Harald

On Thu, Jun 11, 2026, at 10:26, Harald Nordgren wrote:

Yes. Because the git/git repository (on GitHub) is a mirror of his own gitster/git repo (for these branches but not topic branches).

When he is away and there is an interim maintainer, they may push to these branches on their own repos and use git/git as a mirror. So I guess they all have commit access to git/git.

That is my understanding of the matter and what I have observed.

Thanks for the explanation.

Harald