git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3] git-gui: silence install recipes under "make -s"

From
Harald Nordgren via GitGitGadget <gitgitgadget@gmail.com>
Date
Jun 4, 2026, 06:48 UTC
Message-ID
<pull.2318.v3.git.git.1780555730228.gitgitgadget@gmail.com>
In-Reply-To
<pull.2318.v2.git.git.1780510415838.gitgitgadget@gmail.com>
From: Harald Nordgren <haraldnordgren@gmail.com>

Several install and uninstall recipes embed "echo" calls that fire as part of the recipe itself, so the install banners (DEST, INSTALL, LINK, REMOVE) were visible whenever the variables expand non-empty.

Guard the whole "ifndef V" block on "-s" so the loud variants are selected only when "-s" is absent and V=1 is unset. The existing "-s" check also had its findstring arguments in the wrong order (needle "-s" never fit in haystack "s"), so swap them while moving the check to wrap the block.

Signed-off-by: Harald Nordgren <harald.nordgren@kostdoktorn.se>
---
    git-gui: silence install recipes under "make -s"
    
    Added sentences to the commit message noting that the old findstring arg
    order was broken (needle never fit haystack).
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2318%2FHaraldNordgren%2Fgit-gui-respect-silent-flag-v3
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2318/HaraldNordgren/git-gui-respect-silent-flag-v3
Pull-Request: https://github.com/git/git/pull/2318
Range-diff vs v2:
 1:  4e4029c8e8 ! 1:  1375fdc1aa git-gui: silence install recipes under "make -s"
     @@ Commit message
          LINK, REMOVE) were visible whenever the variables expand non-empty.
      
          Guard the whole "ifndef V" block on "-s" so the loud variants are
     -    selected only when "-s" is absent and V=1 is unset.
     +    selected only when "-s" is absent and V=1 is unset. The existing
     +    "-s" check also had its findstring arguments in the wrong order
     +    (needle "-s" never fit in haystack "s"), so swap them while moving
     +    the check to wrap the block.
      
          Signed-off-by: Harald Nordgren <harald.nordgren@kostdoktorn.se>
      
 git-gui/Makefile | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/git-gui/Makefile b/git-gui/Makefile
index ca01068810..d33204e875 100644
--- a/git-gui/Makefile
+++ b/git-gui/Makefile
@@ -64,6 +64,7 @@ REMOVE_F0  = $(RM_RF) # space is required here
 REMOVE_F1  =
 CLEAN_DST  = true
 
+ifneq ($(findstring s,$(firstword -$(MAKEFLAGS))),s)
 ifndef V
 	QUIET          = @
 	QUIET_GEN      = $(QUIET)echo '   ' GEN '$@' &&
@@ -89,6 +90,7 @@ ifndef V
 	REMOVE_F0 = dst=
 	REMOVE_F1 = && echo '   ' REMOVE `basename "$$dst"` && $(RM_RF) "$$dst"
 endif
+endif
 
 TCLTK_PATH ?= wish
 ifeq (./,$(dir $(TCLTK_PATH)))
@@ -97,10 +99,6 @@ else
 	TCL_PATH ?= $(dir $(TCLTK_PATH))$(notdir $(subst wish,tclsh,$(TCLTK_PATH)))
 endif
 
-ifeq ($(findstring $(firstword -$(MAKEFLAGS)),s),s)
-QUIET_GEN =
-endif
-
 -include config.mak
 
 DESTDIR_SQ = $(subst ','\'',$(DESTDIR))

base-commit: 9ac3f193c05c2237e2b14ebaa1149e9fc8a1abe0
-- 
gitgitgadget
Previous: Johannes SixtNext: Johannes Sixt
Message 6 of 14 in “git-gui: silence install recipes under "make -s"”
  1. git-gui: silence install recipes under "make -s"Harald Nordgren via GitGitGadget, Jun 3, 2026
  2. Johannes SixtJun 3, 2026
  3. Harald NordgrenJun 3, 2026
  4. git-gui: silence install recipes under "make -s"Harald Nordgren via GitGitGadget, Jun 3, 2026
  5. Johannes SixtJun 3, 2026
  6. git-gui: silence install recipes under "make -s"Harald Nordgren via GitGitGadget, Jun 4, 2026
  7. Johannes SixtJun 6, 2026
  8. git-gui: silence install recipes under "make -s"Harald Nordgren via GitGitGadget, Jun 6, 2026
  9. Johannes SixtJun 6, 2026
  10. Harald NordgrenJun 10, 2026
  11. Johannes SixtJun 11, 2026
  12. Harald NordgrenJun 11, 2026
  13. Kristoffer HaugsbakkJun 11, 2026
  14. Harald NordgrenJun 11, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.