git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-gui: silence install recipes under "make -s"

From
Harald Nordgren <haraldnordgren@gmail.com>
Date
Jun 3, 2026, 18:03 UTC
Message-ID
<CAHwyqnWsA_s7bXoFZWgUmMW7b9x9H4KmSvgvc1FVt6nyH3HnLA@mail.gmail.com>
In-Reply-To
<010c001d-e241-475d-99ba-f60f71d3365f@kdbg.org>
> Can we please mention shared.mak in a way that doesn't assume that this
> patch was made in the Git repository?
Good point!
Show 16 quoted lines
> > +ifneq ($(findstring s,$(firstword -$(MAKEFLAGS))),s)
> >  ifndef V
> >       QUIET          = @
> >       QUIET_GEN      = $(QUIET)echo '   ' GEN '$@' &&
> > @@ -89,6 +90,7 @@ ifndef V
> >       REMOVE_F0 = dst=
> >       REMOVE_F1 = && echo '   ' REMOVE `basename "$$dst"` && $(RM_RF) "$$dst"
> >  endif
> > +endif
>
> > -ifeq ($(findstring $(firstword -$(MAKEFLAGS)),s),s)
>
> I would have expected that the old and the new condition expressions
> only differ in the ifeq vs. ifneq, but they are different in more than
> that. Assuming that the new expression is correct, was the old one
> incorrect?

Yeah, the old format doesn't seem to work when I use that with ifneq. So I took this other format that is also used twice in shared.mak (lines 40 and 46).

Harald
Previous: Johannes SixtNext: Harald Nordgren via GitGitGadget
Message 3 of 14 in “git-gui: silence install recipes under "make -s"”
  1. git-gui: silence install recipes under "make -s"Harald Nordgren via GitGitGadget, Jun 3, 2026
  2. Johannes SixtJun 3, 2026
  3. Harald NordgrenJun 3, 2026
  4. git-gui: silence install recipes under "make -s"Harald Nordgren via GitGitGadget, Jun 3, 2026
  5. Johannes SixtJun 3, 2026
  6. git-gui: silence install recipes under "make -s"Harald Nordgren via GitGitGadget, Jun 4, 2026
  7. Johannes SixtJun 6, 2026
  8. git-gui: silence install recipes under "make -s"Harald Nordgren via GitGitGadget, Jun 6, 2026
  9. Johannes SixtJun 6, 2026
  10. Harald NordgrenJun 10, 2026
  11. Johannes SixtJun 11, 2026
  12. Harald NordgrenJun 11, 2026
  13. Kristoffer HaugsbakkJun 11, 2026
  14. Harald NordgrenJun 11, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.