Re: [PATCH] git-gui: silence install recipes under "make -s"
- From
Harald Nordgren <haraldnordgren@gmail.com>
- Date
- Jun 3, 2026, 18:03 UTC
- Message-ID
- <CAHwyqnWsA_s7bXoFZWgUmMW7b9x9H4KmSvgvc1FVt6nyH3HnLA@mail.gmail.com>
- In-Reply-To
- <010c001d-e241-475d-99ba-f60f71d3365f@kdbg.org>
> Can we please mention shared.mak in a way that doesn't assume that this > patch was made in the Git repository?
Good point!
Show 16 quoted lines
> > +ifneq ($(findstring s,$(firstword -$(MAKEFLAGS))),s) > > ifndef V > > QUIET = @ > > QUIET_GEN = $(QUIET)echo ' ' GEN '$@' && > > @@ -89,6 +90,7 @@ ifndef V > > REMOVE_F0 = dst= > > REMOVE_F1 = && echo ' ' REMOVE `basename "$$dst"` && $(RM_RF) "$$dst" > > endif > > +endif > > > -ifeq ($(findstring $(firstword -$(MAKEFLAGS)),s),s) > > I would have expected that the old and the new condition expressions > only differ in the ifeq vs. ifneq, but they are different in more than > that. Assuming that the new expression is correct, was the old one > incorrect?
Yeah, the old format doesn't seem to work when I use that with ifneq. So I took this other format that is also used twice in shared.mak (lines 40 and 46).
Harald