Re: [PATCH v3 7/7] git-sh-setup: don't mark trees not used in-tree for i18n

From: Johannes Sixt <j6t@kdbg.org>
Date: Mar 27, 2022, 10:47 UTC
Message-ID: <2e2d20d6-a33d-b223-d364-ab43d92dd220@kdbg.org>
In-Reply-To: <patch-v3-7.7-7a82b1fd005-20220326T171200Z-avarab@gmail.com>

Am 26.03.22 um 18:14 schrieb Ævar Arnfjörð Bjarmason:

Show 6 quoted lines

> Partially revert d323c6b6410 (i18n: git-sh-setup.sh: mark strings for
> translation, 2016-06-17).
> 
> These strings are no longer used in-tree, and we shouldn't be wasting
> translator time on them for the benefit of a hypothetical out-of-tree
> user of git-sh-setup.sh.

There is public documentation for these functions. Hence, you must assume that they are used in scripts outside of Git. Castrating their functionality like this patch does is unacceptable.

-- Hannes

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.