git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 0/7] various: remove dead code, drop i18n not used in-tree

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Mar 26, 2022, 17:14 UTC
Message-ID
<cover-v3-0.7-00000000000-20220326T171200Z-avarab@gmail.com>
In-Reply-To
<cover-v2-0.5-00000000000-20211119T202455Z-avarab@gmail.com>

An altered version of https://lore.kernel.org/git/cover-v2-0.5-00000000000-20211119T202455Z-avarab@gmail.com sent a while ago, I ejected the json-writer.[ch] change, which had objections (on the v1, but it seems E-Mails were crossed).

A the range-diff shows there's a couple of new trivial patches at the start.

I then added a patch to the end to remove some i18n-markings that aren't used anywhere in-tree, let's not waste time translating things for hypothetical out-of-tree users as we migrate the last bits of functionality away from shellscripts.

Ævar Arnfjörð Bjarmason (7):
  run-command.h: remove always unused "clean_on_exit_handler_cbdata"
  configure.ac: remove USE_PIC comment
  xdiff/xmacros.h: remove unused XDL_PTRFREE
  pack-bitmap-write: remove unused bitmap_reset() function
  object-store.h: remove unused has_sha1_file*()
  alloc.[ch]: remove alloc_report() function
  git-sh-setup: don't mark trees not used in-tree for i18n
 alloc.c                                       | 21 -------------------
 alloc.h                                       |  1 -
 configure.ac                                  |  3 ---
 .../coccinelle/the_repository.pending.cocci   | 15 -------------
 ewah/bitmap.c                                 |  5 -----
 ewah/ewok.h                                   |  1 -
 git-sh-setup.sh                               | 20 +++++++++++-------
 object-store.h                                |  4 ----
 run-command.h                                 |  1 -
 xdiff/xmacros.h                               |  1 -
 10 files changed, 13 insertions(+), 59 deletions(-)
Range-diff against v2:
-:  ----------- > 1:  bac78566135 run-command.h: remove always unused "clean_on_exit_handler_cbdata"
-:  ----------- > 2:  93dc689e1aa configure.ac: remove USE_PIC comment
1:  1e7e6d8d482 = 3:  05adde5b9e4 xdiff/xmacros.h: remove unused XDL_PTRFREE
2:  c9026af8953 = 4:  6bd89f3cf42 pack-bitmap-write: remove unused bitmap_reset() function
3:  6d0ca249001 = 5:  cf7969f8f67 object-store.h: remove unused has_sha1_file*()
4:  672bdffde83 ! 6:  b60a4c24a28 alloc.[ch]: remove alloc_report() function
    @@ Commit message
         appears to have been used for demonstration purposes in that commit
         message.
     
    +    These might be handy to manually use in a debugger, but keeping them
    +    and the "count" member of "alloc_state" just for that doesn't seem
    +    worth it.
    +
         Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
     
      ## alloc.c ##
    +@@ alloc.c: union any_object {
    + };
    + 
    + struct alloc_state {
    +-	int count; /* total number of nodes allocated */
    + 	int nr;    /* number of nodes left in current allocation */
    + 	void *p;   /* first free node in current allocation */
    + 
    +@@ alloc.c: static inline void *alloc_node(struct alloc_state *s, size_t node_size)
    + 		s->slabs[s->slab_nr++] = s->p;
    + 	}
    + 	s->nr--;
    +-	s->count++;
    + 	ret = s->p;
    + 	s->p = (char *)s->p + node_size;
    + 	memset(ret, 0, node_size);
     @@ alloc.c: void *alloc_commit_node(struct repository *r)
      	init_commit_node(c);
      	return c;
5:  818f1a46d66 < -:  ----------- json-writer.[ch]: remove unused formatting functions
-:  ----------- > 7:  7a82b1fd005 git-sh-setup: don't mark trees not used in-tree for i18n
-- 
2.35.1.1535.gf8d72b9da1e
Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 23 of 51 in “various: remove dead code”
  1. 0/6 various: remove dead codeÆvar Arnfjörð Bjarmason, Nov 19, 2021
  2. 1/6 xdiff/xmacros.h: remove unused XDL_PTRFREEÆvar Arnfjörð Bjarmason, Nov 19, 2021
  3. Jeff KingNov 19, 2021
  4. 2/6 pack-bitmap-write: remove unused bitmap_reset() functionÆvar Arnfjörð Bjarmason, Nov 19, 2021
  5. Jeff KingNov 19, 2021
  6. 3/6 object-store.h: remove unused has_sha1_file*()Ævar Arnfjörð Bjarmason, Nov 19, 2021
  7. Jeff KingNov 19, 2021
  8. 4/6 alloc.[ch]: remove alloc_report() functionÆvar Arnfjörð Bjarmason, Nov 19, 2021
  9. Junio C HamanoNov 19, 2021
  10. 5/6 strbuf: remove unused istarts_with() functionÆvar Arnfjörð Bjarmason, Nov 19, 2021
  11. Jeff KingNov 19, 2021
  12. Junio C HamanoNov 19, 2021
  13. 6/6 json-writer.[ch]: remove unused formatting functionsÆvar Arnfjörð Bjarmason, Nov 19, 2021
  14. Jeff KingNov 19, 2021
  15. Junio C HamanoNov 19, 2021
  16. Jeff KingNov 19, 2021
  17. 0/5 various: remove dead codeÆvar Arnfjörð Bjarmason, Nov 19, 2021
  18. 1/5 xdiff/xmacros.h: remove unused XDL_PTRFREEÆvar Arnfjörð Bjarmason, Nov 19, 2021
  19. 2/5 pack-bitmap-write: remove unused bitmap_reset() functionÆvar Arnfjörð Bjarmason, Nov 19, 2021
  20. 5/5 json-writer.[ch]: remove unused formatting functionsÆvar Arnfjörð Bjarmason, Nov 19, 2021
  21. 4/5 alloc.[ch]: remove alloc_report() functionÆvar Arnfjörð Bjarmason, Nov 19, 2021
  22. 3/5 object-store.h: remove unused has_sha1_file*()Ævar Arnfjörð Bjarmason, Nov 19, 2021
  23. 0/7 various: remove dead code, drop i18n not used in-treeÆvar Arnfjörð Bjarmason, Mar 26, 2022
  24. 1/7 run-command.h: remove always unused "clean_on_exit_handler_cbdata"Ævar Arnfjörð Bjarmason, Mar 26, 2022
  25. 4/7 pack-bitmap-write: remove unused bitmap_reset() functionÆvar Arnfjörð Bjarmason, Mar 26, 2022
  26. 3/7 xdiff/xmacros.h: remove unused XDL_PTRFREEÆvar Arnfjörð Bjarmason, Mar 26, 2022
  27. 2/7 configure.ac: remove USE_PIC commentÆvar Arnfjörð Bjarmason, Mar 26, 2022
  28. 5/7 object-store.h: remove unused has_sha1_file*()Ævar Arnfjörð Bjarmason, Mar 26, 2022
  29. 6/7 alloc.[ch]: remove alloc_report() functionÆvar Arnfjörð Bjarmason, Mar 26, 2022
  30. 7/7 git-sh-setup: don't mark trees not used in-tree for i18nÆvar Arnfjörð Bjarmason, Mar 26, 2022
  31. Johannes SixtMar 27, 2022
  32. Ævar Arnfjörð BjarmasonMar 27, 2022
  33. Johannes SixtMar 28, 2022
  34. Ævar Arnfjörð BjarmasonMar 28, 2022
  35. Johannes SixtMar 28, 2022
  36. Phillip WoodMar 31, 2022
  37. Ævar Arnfjörð BjarmasonMar 31, 2022
  38. Johannes SixtMar 31, 2022
  39. Ævar Arnfjörð BjarmasonApr 2, 2022
  40. Johannes SixtApr 2, 2022
  41. Ævar Arnfjörð BjarmasonApr 3, 2022
  42. Johannes SixtApr 4, 2022
  43. 0/6 various: remove dead codeÆvar Arnfjörð Bjarmason, Mar 31, 2022
  44. 1/6 run-command.h: remove always unused "clean_on_exit_handler_cbdata"Ævar Arnfjörð Bjarmason, Mar 31, 2022
  45. Junio C HamanoMar 31, 2022
  46. 3/6 xdiff/xmacros.h: remove unused XDL_PTRFREEÆvar Arnfjörð Bjarmason, Mar 31, 2022
  47. 4/6 pack-bitmap-write: remove unused bitmap_reset() functionÆvar Arnfjörð Bjarmason, Mar 31, 2022
  48. Junio C HamanoMar 31, 2022
  49. 5/6 object-store.h: remove unused has_sha1_file*()Ævar Arnfjörð Bjarmason, Mar 31, 2022
  50. 6/6 alloc.[ch]: remove alloc_report() functionÆvar Arnfjörð Bjarmason, Mar 31, 2022
  51. 2/6 configure.ac: remove USE_PIC commentÆvar Arnfjörð Bjarmason, Mar 31, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.