Re: [PATCH 6/6] json-writer.[ch]: remove unused formatting functions

From: Jeff King <peff@peff.net>
Date: Nov 19, 2021, 14:41 UTC
Message-ID: <YZe3nRLPV4FrzbDq@coredump.intra.peff.net>
In-Reply-To: <patch-6.6-e14ee1f8c47-20211119T124420Z-avarab@gmail.com>

On Fri, Nov 19, 2021 at 01:46:26PM +0100, Ævar Arnfjörð Bjarmason wrote:

> These were added in 75459410edd (json_writer: new routines to create
> JSON data, 2018-07-13) for future use with trace2, but have not been
> used by anything. These are easy enough to bring back should we need
> them, but until then there's no point in carrying them.

This is another one where I could _imagine_ somebody using these in a custom patch or topic in flight (though I don't have any such case myself). And they complete the json-writer API, so keeping them is not that ugly.

But I'm also OK with dropping them under the notion of cleanliness, and that they're easy-ish to resurrect.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.