Re: [PATCH v4 1/6] run-command.h: remove always unused "clean_on_exit_handler_cbdata"

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 31, 2022, 22:03 UTC
Message-ID: <xmqqh77dzso8.fsf@gitster.g>
In-Reply-To: <patch-v4-1.6-fc55b203474-20220331T014349Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

Show 21 quoted lines

> Remove a "struct child_process" member added in
> ac2fbaa674c (run-command: add clean_on_exit_handler, 2016-10-16), but
> which was never used.
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
>  run-command.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/run-command.h b/run-command.h
> index 07bed6c31b4..5bd0c933e80 100644
> --- a/run-command.h
> +++ b/run-command.h
> @@ -142,7 +142,6 @@ struct child_process {
>  	unsigned clean_on_exit:1;
>  	unsigned wait_after_clean:1;
>  	void (*clean_on_exit_handler)(struct child_process *process);
> -	void *clean_on_exit_handler_cbdata;
>  };
>  
>  #define CHILD_PROCESS_INIT { \

Thanks for digging.  Looks good.