Re: [PATCH 3/6] object-store.h: remove unused has_sha1_file*()

From: Jeff King <peff@peff.net>
Date: Nov 19, 2021, 14:34 UTC
Message-ID: <YZe13Blt/NXy85gS@coredump.intra.peff.net>
In-Reply-To: <patch-3.6-62ed0ec6077-20211119T124420Z-avarab@gmail.com>

On Fri, Nov 19, 2021 at 01:46:23PM +0100, Ævar Arnfjörð Bjarmason wrote:

Show 10 quoted lines

> These macros were last used in 5d3679ee023 (sha1-file: drop
> has_sha1_file(), 2019-01-07), so let's remove coccinelle migration
> rules added 9b45f499818 (object-store: prepare has_{sha1, object}_file
> to handle any repo, 2018-11-13), along with the compatibility macros
> themselves.
> 
> The "These functions.." in the diff context and the general comment
> about compatibility macros still applies to
> "NO_THE_REPOSITORY_COMPATIBILITY_MACROS" use just a few lines below
> this, so let's keep the comment.

Yep, makes sense. I cleaned up the object_id.cocci file, but didn't think to look for the_repository rules or helpers. Nice to see this going away, too.

-Peff