From: Johannes Sixt Date: Sun, 27 Mar 2022 10:47:26 GMT Subject: Re: [PATCH v3 7/7] git-sh-setup: don't mark trees not used in-tree for i18n Message-ID: <2e2d20d6-a33d-b223-d364-ab43d92dd220@kdbg.org> In-Reply-To: Am 26.03.22 um 18:14 schrieb Ævar Arnfjörð Bjarmason: > Partially revert d323c6b6410 (i18n: git-sh-setup.sh: mark strings for > translation, 2016-06-17). > > These strings are no longer used in-tree, and we shouldn't be wasting > translator time on them for the benefit of a hypothetical out-of-tree > user of git-sh-setup.sh. There is public documentation for these functions. Hence, you must assume that they are used in scripts outside of Git. Castrating their functionality like this patch does is unacceptable. -- Hannes