Re: [PATCH v2 0/9] 'test_i18ngrep'-related fixes and improvements

From: Jeff King <peff@peff.net>
Date: Feb 8, 2018, 16:36 UTC
Message-ID: <20180208163647.GB13078@sigill.intra.peff.net>
In-Reply-To: <20180208155656.9831-1-szeder.dev@gmail.com>

On Thu, Feb 08, 2018 at 04:56:47PM +0100, SZEDER Gábor wrote:

Show 9 quoted lines

> This is the second version of 'sg/test-i18ngrep'.
> 
> To recap, this patch series fixes a couple of bogus 'test_i18ngrep'
> invocations (patches 1-4), tries to prevent similar bugs in the future
> (patch 8), teaches 'test_i18ngrep' to be more informative on failure
> (patch 9), and a bit of cleanups in between (patches 5-7).
> 
> Changes since the previous version [1]:
> [...]

This round looks good to me. I left a very minor comment on patch 8, but otherwise didn't find anything wrong. Thanks.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.