From: Jeff King Date: Thu, 08 Feb 2018 16:36:47 GMT Subject: Re: [PATCH v2 0/9] 'test_i18ngrep'-related fixes and improvements Message-ID: <20180208163647.GB13078@sigill.intra.peff.net> In-Reply-To: <20180208155656.9831-1-szeder.dev@gmail.com> On Thu, Feb 08, 2018 at 04:56:47PM +0100, SZEDER Gábor wrote: > This is the second version of 'sg/test-i18ngrep'. > > To recap, this patch series fixes a couple of bogus 'test_i18ngrep' > invocations (patches 1-4), tries to prevent similar bugs in the future > (patch 8), teaches 'test_i18ngrep' to be more informative on failure > (patch 9), and a bit of cleanups in between (patches 5-7). > > Changes since the previous version [1]: > [...] This round looks good to me. I left a very minor comment on patch 8, but otherwise didn't find anything wrong. Thanks. -Peff