Re: [PATCH 05/10] t5510: consolidate 'grep' and 'test_i18ngrep' patterns
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 26, 2018, 19:23 UTC
- Message-ID
- <xmqqk1w477c3.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <CAM0VKjm0uveCRpNy8H+inwTKa6fzHAjGn=f9tmQ4p1MCWGuirQ@mail.gmail.com>
SZEDER Gábor <szeder.dev@gmail.com> writes:
> No, GETTEXT_POISON only affects the translated messages, but those > 'grep' invocations looked only at refnames and formatting.
You are right for this specific case, but I was talking more from general principle---running test_i18ngrep on an output from grep should be flagged as anti-pattern (I recall vaguly finding an instance not in too distant past).