Re: [PATCH 10/10] t: make 'test_i18ngrep' more informative on failure
- From
Jeff King <peff@peff.net>
- Date
- Jan 26, 2018, 19:25 UTC
- Message-ID
- <20180126192532.GA29438@sigill.intra.peff.net>
- In-Reply-To
- <CAM0VKj=Qsbkog+rj94bZOk=G-XBsXAqQnRUo4eCXQq2LKjre-w@mail.gmail.com>
On Fri, Jan 26, 2018 at 08:23:24PM +0100, SZEDER Gábor wrote:
Show 18 quoted lines
> On Fri, Jan 26, 2018 at 7:50 PM, Jeff King <peff@peff.net> wrote: > > On Fri, Jan 26, 2018 at 01:37:08PM +0100, SZEDER Gábor wrote: > > > >> When 'test_i18ngrep' can't find the expected pattern, it exits > >> completely silently; when its negated form does find the pattern that > >> shouldn't be there, it prints the matching line(s) but otherwise exits > >> without any error message. This leaves the developer puzzled about > >> what could have gone wrong. > >> > >> Make 'test_i18ngrep' more informative on failure by printing an error > >> message including the invoked 'grep' command and the contents of the > >> file it had to scan through. > > > > I think this is an improvement. You can also use "-x" to get a better > > sense of exactly which command failed, > > Yeah, I know... but I have some issues with running tests with '-x'; I > suspect PEBKAC, but haven't yet got around to investigate.
Some tests absolutely fail with "-x", due to them caring about the stderr output of shell functions. But with the BASH_XTRACEFD stuff, if you run suite under bash it should al Just Work (and I recently added TEST_SHELL_PATH to use bash just for the test suite without building all of the scripts with it).
-Peff