Re: [PATCH 09/10] t: make sure that 'test_i18ngrep' got enough parameters

From: Jeff King <peff@peff.net>
Date: Jan 26, 2018, 18:47 UTC
Message-ID: <20180126184736.GF27618@sigill.intra.peff.net>
In-Reply-To: <20180126123708.21722-10-szeder.dev@gmail.com>

On Fri, Jan 26, 2018 at 01:37:07PM +0100, SZEDER Gábor wrote:

Show 5 quoted lines

> Two of the previous patches in this series fixed two bogus
> 'test_i18ngrep' invocations that had neither a filename parameter not
> anything piped into their standard input, yet both managed to remain
> unnoticed for years.  A third similarly bogus invocation is currently
> lurking in 'pu' for a couple of weeks now.

Hrm. At first I thought this was redundant with the stdin thing in the previous one. But that is only checking "did you _try_ to use stdin". This is checking "did you accidentally use stdin, which was empty".

But I think maybe it's the opposite; the other one is redundant with this one, since it would be hard to convince grep to read from stdin anyway with this.

Show 5 quoted lines

> Note that this is not quite perfect, as it doesn't account for any
> 'grep --options' given as parameters.  However, doing so would be far
> too complicated, considering that patters can start with dashes as
> well, and in the majority of the cases we don't use any such options
> anyway.

Yeah, I agree this would help most cases, but not hurt in others. I do think Junio's "see if the final argument is a file" approach seems like it would cover us pretty accurately, though, without having to get too intimate with grep options.

-Peff