Re: [PATCH 02/10] t5812: add 'test_i18ngrep's missing filename parameter
- From
Simon Ruderich <simon@ruderich.org>
- Date
- Jan 30, 2018, 09:50 UTC
- Message-ID
- <20180130095017.GA7722@ruderich.org>
- In-Reply-To
- <20180126123708.21722-3-szeder.dev@gmail.com>
On Fri, Jan 26, 2018 at 01:37:00PM +0100, SZEDER Gábor wrote:
Show 14 quoted lines
> [snip]
>
> diff --git a/t/t5812-proto-disable-http.sh b/t/t5812-proto-disable-http.sh
> index d911afd24..226a4920c 100755
> --- a/t/t5812-proto-disable-http.sh
> +++ b/t/t5812-proto-disable-http.sh
> @@ -21,8 +21,7 @@ test_expect_success 'curl redirects respect whitelist' '
> GIT_SMART_HTTP=0 \
> git clone "$HTTPD_URL/ftp-redir/repo.git" 2>stderr &&
> {
> - test_i18ngrep "ftp.*disabled" stderr ||
> - test_i18ngrep "your curl version is too old"
> + test_i18ngrep -E "(ftp.*disabled|your curl version is too old)" stderr
> }I think we can drop the curly braces as well, as they were only used to group the ||; leaving only:
> + test_i18ngrep -E "(ftp.*disabled|your curl version is too old)" stderr
Regards Simon
-- + privacy is necessary + using gnupg http://gnupg.org + public key id: 0x92FEFDB7E44C32F9