Re: [PATCH v7 1/2] exec_cmd: expose is_executable function

From: Brandon Williams <bmwill@google.com>
Date: Apr 25, 2017, 18:38 UTC
Message-ID: <20170425183829.GC105623@google.com>
In-Reply-To: <73f07d3e-b2a2-0073-8fba-6f7f51f64a7d@kdbg.org>

On 04/25, Johannes Sixt wrote:

Show 7 quoted lines

> Am 25.04.2017 um 19:54 schrieb Brandon Williams:
> >Move the logic for 'is_executable()' from help.c to exec_cmd.c and
> >expose it so that callers from outside help.c can access the function.
> 
> The function is quite low-level. IMO, run-command.[ch] would be a
> better home for it. Additionally, that would reduce the number of
> files that contain #ifdef GIT_WINDOWS_NATIVE.

Fair enough, Jonathan suggested the same so I'll move it to run-command in a re-roll.

-- 
Brandon Williams

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.