Re: [PATCH v6 02/11] t0061: run_command executes scripts without a #! line

From: Brandon Williams <bmwill@google.com>
Date: Apr 20, 2017, 16:58 UTC
Message-ID: <20170420165825.GD142567@google.com>
In-Reply-To: <alpine.DEB.2.20.1704201248290.3480@virtualbox>

On 04/20, Johannes Schindelin wrote:

Show 16 quoted lines

> Hi Brandon,
> 
> On Wed, 19 Apr 2017, Brandon Williams wrote:
> 
> > Add a test to 't0061-run-command.sh' to ensure that run_command can
> > continue to execute scripts which don't include a '#!' line.
> > 
> > Signed-off-by: Brandon Williams <bmwill@google.com>
> 
> Please add something like this to the commit message lest future readers
> wonder where that !MINGW comes from:
> 
> 	On Windows, shell scripts are not natively executable. Git has a
> 	workaround to execute them, looking for the shebang line. Shell
> 	scripts without a shebang line will simply not execute on Windows.
> 	Therefore, disable the new test on Windows.

I'm fine with including this in the commit message. If another reroll needs to happen then I can make the update otherwise hopefully Junio can just squash that in.

> 
> Thanks,
> Dscho

-- 
Brandon Williams