Re: [PATCH 7/6] run-command: block signals between fork and execve

From: Brandon Williams <bmwill@google.com>
Date: Apr 14, 2017, 02:42 UTC
Message-ID: <20170414024202.GA27281@google.com>
In-Reply-To: <20170413211428.GA5961@whir>

On 04/13, Eric Wong wrote:

Show 6 quoted lines

> @@ -277,6 +278,8 @@ static void child_err_spew(struct child_process *cmd, struct child_err *cerr)
>  		error_errno("exec '%s': cd to '%s' failed",
>  			    cmd->argv[0], cmd->dir);
>  		break;
> +	case CHILD_ERR_SIGPROCMASK:
> +		error_errno("sigprocmask failed restoring signals");

missing a break statement here I'll add it in, in the re-roll.

>  	case CHILD_ERR_ENOENT:
>  		error_errno("cannot run %s", cmd->argv[0]);
>  		break;

-- 
Brandon Williams

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.