Re: [PATCH v2 1/6] t5550: use write_script to generate post-update hook

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Apr 13, 2017, 20:43 UTC
Message-ID: <20170413204358.GA10084@aiede.mtv.corp.google.com>
In-Reply-To: <20170413183252.4713-2-bmwill@google.com>

Hi,

Brandon Williams wrote:

Show 9 quoted lines

> The post-update hooks created in t5550-http-fetch-dumb.sh is missing the
> "!#/bin/sh" line which can cause issues with portability.  Instead
> create the hook using the 'write_script' function which includes the
> proper "#!" line.
>
> Signed-off-by: Brandon Williams <bmwill@google.com>
> ---
>  t/t5550-http-fetch-dumb.sh | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

This would allow later patches to regress a previously supported behavior.

I agree that it's silly to test that behavior as a side-effect of this unrelated test, but I don't think we want to lose the test coverage.

Thanks for tracking this down and hope that helps, Jonathan