Re: [PATCH v2 1/6] t5550: use write_script to generate post-update hook

From: Eric Wong <e@80x24.org>
Date: Apr 13, 2017, 20:59 UTC
Message-ID: <20170413205947.GA32659@starla>
In-Reply-To: <20170413204358.GA10084@aiede.mtv.corp.google.com>

Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 5 quoted lines

> Brandon Williams wrote:
> > The post-update hooks created in t5550-http-fetch-dumb.sh is missing the
> > "!#/bin/sh" line which can cause issues with portability.  Instead
> > create the hook using the 'write_script' function which includes the
> > proper "#!" line.

Show 5 quoted lines

> This would allow later patches to regress a previously supported
> behavior.
> 
> I agree that it's silly to test that behavior as a side-effect of this
> unrelated test, but I don't think we want to lose the test coverage.

I was about to write something similar about this regression. The new execve-using code should handle ENOEXEC as execvpe does and probably a new test for it needs to be written.