Re: [PATCH v3 06/10] run-command: don't die in child when duping /dev/null
- From
- Brandon Williams <bmwill@google.com>
- Date
- Apr 14, 2017, 20:19 UTC
- Message-ID
- <20170414201956.GA54940@google.com>
- In-Reply-To
- <20170414193833.GA5290@starla>
On 04/14, Eric Wong wrote:
Show 6 quoted lines
> Brandon Williams <bmwill@google.com> wrote:
> > + if (cmd->no_stdin || cmd->no_stdout || cmd->no_stderr) {
> > + null_fd = open("/dev/null", O_RDWR | O_CLOEXEC | O_NONBLOCK);
>
> O_NONBLOCK? This was in my original patch, too :x
> Wow, I wonder what I was smoking that day...And I apparently wasn't thinking enough to catch that! I'll fix that.
-- Brandon Williams