git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Signed-off-by vs Reviewed-by

From
Jeff King <peff@peff.net>
Date
Mar 31, 2016, 14:32 UTC
Message-ID
<20160331143244.GD31116@sigill.intra.peff.net>
In-Reply-To
<20160331123507.GC19857@collabora.co.uk>
On Thu, Mar 31, 2016 at 02:35:07PM +0200, Miklos Vajna wrote:
Show 11 quoted lines
> Hi,
> 
> Some projects like LibreOffice don't use Signed-off-by, instead usually
> use Gerrit for code review, and reviewers add a Reviewed-by line when
> they are OK with a patch.  In this workflow it's a bit unfortunate that
> adding a Signed-off-by line is just a command-line switch, but adding a
> Reviewed-by line is more complex.
> 
> Is there anything in git that could help this situation? I didn't see
> any related config option; I wonder if a patch would be accepted to make
> the "Signed-off-by" line configurable, or there is a better way.

There's git-interpret-trailers, which can do the heavy lifting of adding it in the right place. But I don't know how you'd want to trigger it; it would depend on the workflow that people use to add their signoff in the first place. I don't think there is anything as easy as "git commit --amend -s", but I'm not all that familiar with the interpret-trailers code.

-Peff
Previous: Miklos VajnaNext: Christian Couder
Message 10 of 11 in “Signed-off-by vs Reviewed-by”
  1. Miklos VajnaMar 31, 2016
  2. Pranit BauvaMar 31, 2016
  3. Miklos VajnaMar 31, 2016
  4. Sidhant SharmaMar 31, 2016
  5. Christian CouderMar 31, 2016
  6. Junio C HamanoMar 31, 2016
  7. Jeff KingMar 31, 2016
  8. Junio C HamanoMar 31, 2016
  9. Miklos VajnaApr 1, 2016
  10. Jeff KingMar 31, 2016
  11. Christian CouderMar 31, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.