Re: Signed-off-by vs Reviewed-by

From: Sidhant Sharma <tigerkid001@gmail.com>
Date: Mar 31, 2016, 14:57 UTC
Message-ID: <56FD3ABC.2000500@gmail.com>
In-Reply-To: <20160331143501.GE19857@collabora.co.uk>

Hi,

On Thursday 31 March 2016 08:05 PM, Miklos Vajna wrote:

Show 12 quoted lines

> Hi,
>
> On Thu, Mar 31, 2016 at 07:54:47PM +0530, Pranit Bauva <pranit.bauva@gmail.com> wrote:
>> Are you suggesting to use a different email address for commiting,
>> signing off and reviewing?
> Let's say project A has a workflow where patch authors and maintainers
> add a "Signed-off-by: A B <a@example.com>" line. This is well-supported
> by git, various commands have a -s option to add that line.
>
> However, if project B has a workflow where patch authors add no such
> line, and reviewers add a "Reviewed-by: A B <a@example.com>" line, then
> you have to add that line manually when you do a review.

When making the string configurable, would it be a good idea to support more than one sign-off strings? For instance, often patches here in Git have both a Signed-Off and a Reviewed-by line. What would you suggest for such a case?

Regards, Sidhant