git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Signed-off-by vs Reviewed-by

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 31, 2016, 16:28 UTC
Message-ID
<xmqqtwjmpq6b.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20160331143501.GE19857@collabora.co.uk>
Miklos Vajna <vmiklos@collabora.co.uk> writes:
> Typing that line (including copy&pasting your name + email all the time)
> is a bit boring.

I think the last message from Christian in the thread points at the right direction in the future.

The internal "parse the existing trailer block and manipulate it by adding, conditionally adding, replacing and deleting it" logic was done as an experimental "interpret-trailers" program, but polishing it (both its design and implementation) and integrating it to the front-line programs (e.g. "git commit") hasn't been done.

As to the last step of "integration", we cannot use short-and-sweet single letter options like '-s' (for sign-off) for each and every custom trailer different projects use for their own purpose (as there are only 26 of the lowercase ASCII alphabet letters), so the most general syntax for the option has to become "--trailer <arg>" or some variation of it, and at that point "-s" would look like a short-hand for "--trailer signed-off-by".

Previous: Christian CouderNext: Jeff King
Message 6 of 11 in “Signed-off-by vs Reviewed-by”
  1. Miklos VajnaMar 31, 2016
  2. Pranit BauvaMar 31, 2016
  3. Miklos VajnaMar 31, 2016
  4. Sidhant SharmaMar 31, 2016
  5. Christian CouderMar 31, 2016
  6. Junio C HamanoMar 31, 2016
  7. Jeff KingMar 31, 2016
  8. Junio C HamanoMar 31, 2016
  9. Miklos VajnaApr 1, 2016
  10. Jeff KingMar 31, 2016
  11. Christian CouderMar 31, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.