Signed-off-by vs Reviewed-by
- From
- Miklos Vajna <vmiklos@collabora.co.uk>
- Date
- Mar 31, 2016, 12:35 UTC
- Message-ID
- <20160331123507.GC19857@collabora.co.uk>
Hi,
Some projects like LibreOffice don't use Signed-off-by, instead usually use Gerrit for code review, and reviewers add a Reviewed-by line when they are OK with a patch. In this workflow it's a bit unfortunate that adding a Signed-off-by line is just a command-line switch, but adding a Reviewed-by line is more complex.
Is there anything in git that could help this situation? I didn't see any related config option; I wonder if a patch would be accepted to make the "Signed-off-by" line configurable, or there is a better way.
Like, would a patch that adds e.g. a core.signedOffString configuration option to make the string customizable welcome?
Thanks,
Miklos