Re: Signed-off-by vs Reviewed-by
- From
- Miklos Vajna <vmiklos@collabora.co.uk>
- Date
- Mar 31, 2016, 14:35 UTC
- Message-ID
- <20160331143501.GE19857@collabora.co.uk>
- In-Reply-To
- <CAFZEwPMzcqrd8NEP6MH5saXL2KdUKAyN51uuoS5=aeU0aPWjJQ@mail.gmail.com>
Hi,
On Thu, Mar 31, 2016 at 07:54:47PM +0530, Pranit Bauva <pranit.bauva@gmail.com> wrote:
> Are you suggesting to use a different email address for commiting, > signing off and reviewing?
Let's say project A has a workflow where patch authors and maintainers add a "Signed-off-by: A B <a@example.com>" line. This is well-supported by git, various commands have a -s option to add that line.
However, if project B has a workflow where patch authors add no such line, and reviewers add a "Reviewed-by: A B <a@example.com>" line, then you have to add that line manually when you do a review.
I suggest to give a bit more support to this workflow in git. One way of doing that would be to make the Signed-off-by string configurable. I can look into implementing that, but first I wanted to discuss the idea here on the list -- perhaps there is a better way to support that. :-)
Typing that line (including copy&pasting your name + email all the time) is a bit boring.
Regards,
Miklos