From: Jeff King <peff@peff.net>
Date: Thu, 31 Mar 2016 14:32:45 GMT
Subject: Re: Signed-off-by vs Reviewed-by
Message-ID: <20160331143244.GD31116@sigill.intra.peff.net>
In-Reply-To: <20160331123507.GC19857@collabora.co.uk>

On Thu, Mar 31, 2016 at 02:35:07PM +0200, Miklos Vajna wrote:

> Hi,
> 
> Some projects like LibreOffice don't use Signed-off-by, instead usually
> use Gerrit for code review, and reviewers add a Reviewed-by line when
> they are OK with a patch.  In this workflow it's a bit unfortunate that
> adding a Signed-off-by line is just a command-line switch, but adding a
> Reviewed-by line is more complex.
> 
> Is there anything in git that could help this situation? I didn't see
> any related config option; I wonder if a patch would be accepted to make
> the "Signed-off-by" line configurable, or there is a better way.

There's git-interpret-trailers, which can do the heavy lifting of adding
it in the right place. But I don't know how you'd want to trigger it; it
would depend on the workflow that people use to add their signoff in the
first place.  I don't think there is anything as easy as "git commit
--amend -s", but I'm not all that familiar with the interpret-trailers
code.

-Peff