git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitk: add support for -G'regex' pickaxe variant

From
Jonathan Nieder <jrnieder@gmail.com>
Date
May 11, 2013, 06:13 UTC
Message-ID
<20130511061322.GB3394@elie>
In-Reply-To
<20130511055647.GA3262@iris.ozlabs.ibm.com>
Paul Mackerras wrote:
Show 6 quoted lines
> I thought I had replied to this patch; maybe I only thought about it.
>
> Given that we already have a selector to choose between exact and
> regexp matching, it seems more natural to use that rather than add a
> new selector entry.  Arguably the "IgnCase" option should be disabled
> when "adding/removing string" is selected.

Thanks. I think I disagree: "log -G" and "log -S" are different operations, not variations on the same one.

The description "Find next commit adding/removing string:" very clearly conveys what "-S" means. Maybe -G would be more clearly described as "Find next commit changing line that matches regex:" or "Find next commit changing line containing:"?

Jonathan
Previous: Paul MackerrasNext: Paul Mackerras
Message 10 of 20 in “gitk: add support for -G'regex' pickaxe variant”
  1. gitk: add support for -G'regex' pickaxe variantMartin Langhoff, Jun 8, 2012
  2. Zbigniew Jędrzejewski-SzmekJun 9, 2012
  3. Junio C HamanoJun 10, 2012
  4. Paul MackerrasJun 10, 2012
  5. Junio C HamanoJun 10, 2012
  6. gitk: add support for -G'regex' pickaxe variantZbigniew Jędrzejewski-Szmek, Jun 14, 2012
  7. Martin LanghoffMay 7, 2013
  8. Felipe ContrerasMay 7, 2013
  9. Paul MackerrasMay 11, 2013
  10. Jonathan NiederMay 11, 2013
  11. Paul MackerrasMay 11, 2013
  12. Martin LanghoffMay 13, 2013
  13. Jonathan NiederMay 13, 2013
  14. Martin LanghoffMay 13, 2013
  15. Jonathan NiederMay 13, 2013
  16. Martin LanghoffMay 13, 2013
  17. Junio C HamanoMay 13, 2013
  18. Ramkumar RamachandraMay 13, 2013
  19. Jonathan NiederMay 13, 2013
  20. Jonathan NiederMay 13, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.