From: Jonathan Nieder <jrnieder@gmail.com>
Date: Sat, 11 May 2013 06:13:22 GMT
Subject: Re: [PATCH] gitk: add support for -G'regex' pickaxe variant
Message-ID: <20130511061322.GB3394@elie>
In-Reply-To: <20130511055647.GA3262@iris.ozlabs.ibm.com>

Paul Mackerras wrote:

> I thought I had replied to this patch; maybe I only thought about it.
>
> Given that we already have a selector to choose between exact and
> regexp matching, it seems more natural to use that rather than add a
> new selector entry.  Arguably the "IgnCase" option should be disabled
> when "adding/removing string" is selected.

Thanks.  I think I disagree: "log -G" and "log -S" are different
operations, not variations on the same one.  

The description "Find next commit adding/removing string:" very
clearly conveys what "-S" means.  Maybe -G would be more clearly
described as "Find next commit changing line that matches regex:" or
"Find next commit changing line containing:"?

Jonathan