git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitk: add support for -G'regex' pickaxe variant

From
Jonathan Nieder <jrnieder@gmail.com>
Date
May 13, 2013, 19:33 UTC
Message-ID
<20130513193320.GC3657@google.com>
In-Reply-To
<CAAhxitGFhVa6+8x_rgNz5dgyr6m4S11fVU2eJNnMuWimGiM8aQ@mail.gmail.com>
Martin Langhoff wrote:
> On Mon, May 13, 2013 at 2:55 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
Show 9 quoted lines
>> My experience is the opposite.  I wonder "What did the author of this
>> nonsense comment mean?" or "What is the purpose of this strange
>> condition in this if () statement?".  Then "git log -S" finds the
>> culprit
>
> Only if that if () statement looks that way from a single commit.
> That's my point. If the line code bit you are looking at is the result
> of several changes, your log -S will grind a while and find you
> nothing.

Well, no, it should find the final change that brought it into the current form. Just like "git blame".

Has it been finding zero results in some cases where the current code matches the pattern? That sounds like a bug.

Previous: Martin LanghoffNext: Martin Langhoff
Message 15 of 20 in “gitk: add support for -G'regex' pickaxe variant”
  1. gitk: add support for -G'regex' pickaxe variantMartin Langhoff, Jun 8, 2012
  2. Zbigniew Jędrzejewski-SzmekJun 9, 2012
  3. Junio C HamanoJun 10, 2012
  4. Paul MackerrasJun 10, 2012
  5. Junio C HamanoJun 10, 2012
  6. gitk: add support for -G'regex' pickaxe variantZbigniew Jędrzejewski-Szmek, Jun 14, 2012
  7. Martin LanghoffMay 7, 2013
  8. Felipe ContrerasMay 7, 2013
  9. Paul MackerrasMay 11, 2013
  10. Jonathan NiederMay 11, 2013
  11. Paul MackerrasMay 11, 2013
  12. Martin LanghoffMay 13, 2013
  13. Jonathan NiederMay 13, 2013
  14. Martin LanghoffMay 13, 2013
  15. Jonathan NiederMay 13, 2013
  16. Martin LanghoffMay 13, 2013
  17. Junio C HamanoMay 13, 2013
  18. Ramkumar RamachandraMay 13, 2013
  19. Jonathan NiederMay 13, 2013
  20. Jonathan NiederMay 13, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.