Re: [PATCH] gitk: add support for -G'regex' pickaxe variant

From: Paul Mackerras <paulus@samba.org>
Date: Jun 10, 2012, 07:24 UTC
Message-ID: <20120610072431.GA20320@bloggs.ozlabs.ibm.com>
In-Reply-To: <7v8vfvbrjt.fsf@alter.siamese.dyndns.org>

On Sat, Jun 09, 2012 at 11:37:58PM -0700, Junio C Hamano wrote:

Show 21 quoted lines

> Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> writes:
> 
> > On 06/08/2012 04:32 AM, Martin Langhoff wrote:
> >> git log -G'regex' is a very usable alternative to the classic
> >> pickaxe. Minimal patch to make it usable from gitk.
> >
> >>      set gm [makedroplist .tf.lbar.gdttype gdttype \
> >>  		[mc "containing:"] \
> >>  		[mc "touching paths:"] \
> >> -		[mc "adding/removing string:"]]
> >> +		[mc "adding/removing string:"] \
> >> +		[mc "changes match regex:"]]
> >
> > Hi,
> >
> > this feature is definitely useful. One nitpick: the string that you add
> > becomes part of a sentence in the GUI: "prev/next commit changes match
> > regex", which is in different grammatical form then the existing
> > snippets. Should be something with '-ing'.
> 
> "prev/next commit with changes matching regex" perhaps?

There is already the drop-down list to select exact, case-ignoring or regexp matching. I would think that "adding/removing string" combined with "Regexp" matching should select this.

What exactly does git log -G do?

Paul.