git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitk: add support for -G'regex' pickaxe variant

From
Martin Langhoff <martin.langhoff@gmail.com>
Date
May 7, 2013, 17:17 UTC
Message-ID
<CACPiFCKev9uibTa8GSH94ZaH-NaVBAWVempg4xfTdFTThE85Zw@mail.gmail.com>
In-Reply-To
<1339698851-15428-1-git-send-email-zbyszek@in.waw.pl>

I just did git rebase origin/master for the umpteenth time, which reminded me this nice patch is still pending.

ping?
m

On Thu, Jun 14, 2012 at 2:34 PM, Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> wrote:

Show 43 quoted lines
> From: Martin Langhoff <martin@laptop.org>
>
> git log -G'regex' is a very usable alternative to the classic
> pickaxe. Minimal patch to make it usable from gitk.
>
> [zj: reword message]
> Signed-off-by: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
> ---
> Martin's off on holidays, so I'm sending v2 after rewording.
>
>  gitk-git/gitk | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/gitk-git/gitk b/gitk-git/gitk
> index 22270ce..24eaead 100755
> --- a/gitk-git/gitk
> +++ b/gitk-git/gitk
> @@ -2232,7 +2232,8 @@ proc makewindow {} {
>      set gm [makedroplist .tf.lbar.gdttype gdttype \
>                 [mc "containing:"] \
>                 [mc "touching paths:"] \
> -               [mc "adding/removing string:"]]
> +               [mc "adding/removing string:"] \
> +               [mc "with changes matching regex:"]]
>      trace add variable gdttype write gdttype_change
>      pack .tf.lbar.gdttype -side left -fill y
>
> @@ -4595,6 +4596,8 @@ proc do_file_hl {serial} {
>         set gdtargs [concat -- $relative_paths]
>      } elseif {$gdttype eq [mc "adding/removing string:"]} {
>         set gdtargs [list "-S$highlight_files"]
> +    } elseif {$gdttype eq [mc "with changes matching regex:"]} {
> +       set gdtargs [list "-G$highlight_files"]
>      } else {
>         # must be "containing:", i.e. we're searching commit info
>         return
> --
> 1.7.11.rc3.129.ga90bc7a.dirty
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
-- 
 martin.langhoff@gmail.com
 -  ask interesting questions
 - don't get distracted with shiny stuff  - working code first
 ~ http://docs.moodle.org/en/User:Martin_Langhoff
Previous: Zbigniew Jędrzejewski-SzmekNext: Felipe Contreras
Message 7 of 20 in “gitk: add support for -G'regex' pickaxe variant”
  1. gitk: add support for -G'regex' pickaxe variantMartin Langhoff, Jun 8, 2012
  2. Zbigniew Jędrzejewski-SzmekJun 9, 2012
  3. Junio C HamanoJun 10, 2012
  4. Paul MackerrasJun 10, 2012
  5. Junio C HamanoJun 10, 2012
  6. gitk: add support for -G'regex' pickaxe variantZbigniew Jędrzejewski-Szmek, Jun 14, 2012
  7. Martin LanghoffMay 7, 2013
  8. Felipe ContrerasMay 7, 2013
  9. Paul MackerrasMay 11, 2013
  10. Jonathan NiederMay 11, 2013
  11. Paul MackerrasMay 11, 2013
  12. Martin LanghoffMay 13, 2013
  13. Jonathan NiederMay 13, 2013
  14. Martin LanghoffMay 13, 2013
  15. Jonathan NiederMay 13, 2013
  16. Martin LanghoffMay 13, 2013
  17. Junio C HamanoMay 13, 2013
  18. Ramkumar RamachandraMay 13, 2013
  19. Jonathan NiederMay 13, 2013
  20. Jonathan NiederMay 13, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.