Re: [PATCH] gitk: add support for -G'regex' pickaxe variant
- From
Paul Mackerras <paulus@samba.org>
- Date
- May 11, 2013, 05:56 UTC
- Message-ID
- <20130511055647.GA3262@iris.ozlabs.ibm.com>
- In-Reply-To
- <CACPiFCKev9uibTa8GSH94ZaH-NaVBAWVempg4xfTdFTThE85Zw@mail.gmail.com>
On Tue, May 07, 2013 at 01:17:18PM -0400, Martin Langhoff wrote:
> I just did git rebase origin/master for the umpteenth time, which > reminded me this nice patch is still pending. > > ping?
I thought I had replied to this patch; maybe I only thought about it.
Given that we already have a selector to choose between exact and regexp matching, it seems more natural to use that rather than add a new selector entry. Arguably the "IgnCase" option should be disabled when "adding/removing string" is selected.
Paul.