git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] revision.c: introduce --notes-ref= to use one notes ref only

From
Johan Herland <johan@herland.net>
Date
Mar 29, 2011, 21:44 UTC
Message-ID
<201103292344.26249.johan@herland.net>
In-Reply-To
<20110329205307.GA30959@sigill.intra.peff.net>
On Tuesday 29 March 2011, Jeff King wrote:
Show 11 quoted lines
> Here's the series I ended up with. Getting the refactoring just right
> turned out to be non-trivial, but between several attempts and some
> tests, I think the end result is correct. Hopefully the breakdown of the
> changes into small patches helps make it easy to review.
> 
>   [1/6]: notes: make expand_notes_ref globally accessible
>   [2/6]: revision.c: refactor notes ref expansion
>   [3/6]: notes: refactor display notes extra refs field
>   [4/6]: notes: refactor display notes default handling
>   [5/6]: revision.c: support --notes command-line option
>   [6/6]: revision.c: make --no-notes reset --notes list
Indeed, the whole series looks good to me.
Acked-by: Johan Herland <johan@herland.net>
Thanks! :)
...Johan
-- 
Johan Herland, <johan@herland.net>
www.herland.net
Previous: Junio C HamanoNext: Johan Herland
Message 15 of 23 in “revision.c: introduce --notes-ref= to use one notes ref only”
  1. revision.c: introduce --notes-ref= to use one notes ref onlyMichael J Gruber, Mar 29, 2011
  2. Johan HerlandMar 29, 2011
  3. Jeff KingMar 29, 2011
  4. Michael J GruberMar 29, 2011
  5. Junio C HamanoMar 29, 2011
  6. Jeff KingMar 29, 2011
  7. 1/6 notes: make expand_notes_ref globally accessibleJeff King, Mar 29, 2011
  8. 2/6 revision.c: refactor notes ref expansionJeff King, Mar 29, 2011
  9. 3/6 notes: refactor display notes extra refs fieldJeff King, Mar 29, 2011
  10. 4/6 notes: refactor display notes default handlingJeff King, Mar 29, 2011
  11. Junio C HamanoMar 29, 2011
  12. 5/6 revision.c: support --notes command-line optionJeff King, Mar 29, 2011
  13. 6/6 revision.c: make --no-notes reset --notes listJeff King, Mar 29, 2011
  14. Junio C HamanoMar 29, 2011
  15. Johan HerlandMar 29, 2011
  16. 7/6 log/pretty-options: Document --[no-]notes and deprecate old notes optionsJohan Herland, Mar 29, 2011
  17. Jeff KingMar 30, 2011
  18. 7/6 log/pretty-options: Document --[no-]notes and deprecate old notes optionsJohan Herland, Mar 30, 2011
  19. Jeff KingMar 30, 2011
  20. Jeff KingMar 29, 2011
  21. Jeff KingMar 29, 2011
  22. Michael J GruberMar 29, 2011
  23. Jeff KingMar 29, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.