Re: [PATCH 6/6] revision.c: make --no-notes reset --notes list

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 29, 2011, 22:04 UTC
Message-ID: <7v8vvxpor9.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20110329205942.GF23466@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 7 quoted lines

> Technically this is a regression for:
>
>   git log --show-notes=foo --no-notes --show-notes=bar
>
> which used to show both. But I consider that behavior useless and crazy,
> and since the --no-notes actually did nothing there, why would anyone
> have been using it?

I suspect that nobody would complain; we could even ridicule whoever claim to have been depending on the buggy behaviour.

    It was a _bug_ that 'git log' still showed A when it is ran with
    '--show-notes=A --no-notes --show-notes=B'

may even be more appropriate description of this change.

Thanks for bringing in a bit more sanity to the world.