git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] revision.c: introduce --notes-ref= to use one notes ref only

From
Johan Herland <johan@herland.net>
Date
Mar 29, 2011, 12:39 UTC
Message-ID
<201103291439.17197.johan@herland.net>
In-Reply-To
<e83f8b622fba5add563fc331ae3922b79a0af008.1301392999.git.git@drmicha.warpmail.net>
On Tuesday 29 March 2011, Michael J Gruber wrote:
Show 10 quoted lines
> As notes become increasingly popular, it's often interesting to show
> notes from a particular notes ref only. Introduce '--notes-ref=<ref>'
> as a convenience shortcut for '--no-standard-notes
> --show-notes=<ref>'.
>
> Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
> ---
> The idea is to use the same name as in "git notes --ref=<ref>" but
> make it clear for the rev-list option to be about notes, thus
> "--notes-ref=<ref>".

The idea and implementation look good to me. Not sure I like the option "bloat" (somehow feels it should be possible to express the same behavior using fewer options), but if there's not a better way to reorganize the options, then you can consider it Acked-by me.

Thanks! :)
...Johan
-- 
Johan Herland, <johan@herland.net>
www.herland.net
Previous: Michael J GruberNext: Jeff King
Message 2 of 23 in “revision.c: introduce --notes-ref= to use one notes ref only”
  1. revision.c: introduce --notes-ref= to use one notes ref onlyMichael J Gruber, Mar 29, 2011
  2. Johan HerlandMar 29, 2011
  3. Jeff KingMar 29, 2011
  4. Michael J GruberMar 29, 2011
  5. Junio C HamanoMar 29, 2011
  6. Jeff KingMar 29, 2011
  7. 1/6 notes: make expand_notes_ref globally accessibleJeff King, Mar 29, 2011
  8. 2/6 revision.c: refactor notes ref expansionJeff King, Mar 29, 2011
  9. 3/6 notes: refactor display notes extra refs fieldJeff King, Mar 29, 2011
  10. 4/6 notes: refactor display notes default handlingJeff King, Mar 29, 2011
  11. Junio C HamanoMar 29, 2011
  12. 5/6 revision.c: support --notes command-line optionJeff King, Mar 29, 2011
  13. 6/6 revision.c: make --no-notes reset --notes listJeff King, Mar 29, 2011
  14. Junio C HamanoMar 29, 2011
  15. Johan HerlandMar 29, 2011
  16. 7/6 log/pretty-options: Document --[no-]notes and deprecate old notes optionsJohan Herland, Mar 29, 2011
  17. Jeff KingMar 30, 2011
  18. 7/6 log/pretty-options: Document --[no-]notes and deprecate old notes optionsJohan Herland, Mar 30, 2011
  19. Jeff KingMar 30, 2011
  20. Jeff KingMar 29, 2011
  21. Jeff KingMar 29, 2011
  22. Michael J GruberMar 29, 2011
  23. Jeff KingMar 29, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.