Re: [PATCH] revision.c: introduce --notes-ref= to use one notes ref only

From: Jeff King <peff@peff.net>
Date: Mar 29, 2011, 14:35 UTC
Message-ID: <20110329143547.GB10771@sigill.intra.peff.net>
In-Reply-To: <e83f8b622fba5add563fc331ae3922b79a0af008.1301392999.git.git@drmicha.warpmail.net>

On Tue, Mar 29, 2011 at 12:05:09PM +0200, Michael J Gruber wrote:

Show 12 quoted lines

> -		if (!prefixcmp(arg+13, "refs/"))
> +		if (!prefixcmp(arg+offset, "refs/"))
>  			/* happy */;
> -		else if (!prefixcmp(arg+13, "notes/"))
> +		else if (!prefixcmp(arg+offset, "notes/"))
>  			strbuf_addstr(&buf, "refs/");
>  		else
>  			strbuf_addstr(&buf, "refs/notes/");
> -		strbuf_addstr(&buf, arg+13);
> +		strbuf_addstr(&buf, arg+offset);
>  		string_list_append(revs->notes_opt.extra_notes_refs,
>  				   strbuf_detach(&buf, NULL));

This issue is not introduced by your patch, but maybe it is a good opportunity to refactor this to use expand_notes_ref from notes.c?

-Peff