From: Johan Herland <johan@herland.net>
Date: Tue, 29 Mar 2011 21:44:26 GMT
Subject: Re: [PATCH] revision.c: introduce --notes-ref= to use one notes ref only
Message-ID: <201103292344.26249.johan@herland.net>
In-Reply-To: <20110329205307.GA30959@sigill.intra.peff.net>

On Tuesday 29 March 2011, Jeff King wrote:
> Here's the series I ended up with. Getting the refactoring just right
> turned out to be non-trivial, but between several attempts and some
> tests, I think the end result is correct. Hopefully the breakdown of the
> changes into small patches helps make it easy to review.
> 
>   [1/6]: notes: make expand_notes_ref globally accessible
>   [2/6]: revision.c: refactor notes ref expansion
>   [3/6]: notes: refactor display notes extra refs field
>   [4/6]: notes: refactor display notes default handling
>   [5/6]: revision.c: support --notes command-line option
>   [6/6]: revision.c: make --no-notes reset --notes list

Indeed, the whole series looks good to me.

Acked-by: Johan Herland <johan@herland.net>


Thanks! :)

...Johan

-- 
Johan Herland, <johan@herland.net>
www.herland.net