Re: [PATCH] revision.c: introduce --notes-ref= to use one notes ref only

From: Jeff King <peff@peff.net>
Date: Mar 29, 2011, 20:23 UTC
Message-ID: <20110329202335.GA5997@sigill.intra.peff.net>
In-Reply-To: <4D923792.9010101@drmicha.warpmail.net>

On Tue, Mar 29, 2011 at 09:48:34PM +0200, Michael J Gruber wrote:

Show 11 quoted lines

> >> This issue is not introduced by your patch, but maybe it is a good
> >> opportunity to refactor this to use expand_notes_ref from notes.c?
> > 
> > Oops, I just realized this is in builtin/notes.c in master. I had
> > already written a patch for another topic that made it globally
> > accessible. :)
> 
> Yeah, I (figured and) factored it out myself meanwhile, and rebased. I'm
> wondering though where we are going. Junio seems to be in a mood for
> major changes to the notes ui, so maybe I should hold on until we
> decided about a ui restructuring.

I have a series I'll send in a few minutes. It _would_ be a lot cleaner if we just dropped --show-notes and company entirely, but I think that is perhaps too aggressive, even for such a young feature.

Show 5 quoted lines

> I think, though, that any notes ui revamp is correlated with our
> (stalled?) discussions about the layout of refs/. It affects not only
> the default notes ref ("commits" for all notes?) but also the question
> what a standard notes ref is, and where to store (and how to specify)
> upstream notes refs.

Yeah, I think those are open questions. But we can probably get away with at least this option refactoring without having to answer them.

-Peff