git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-gui: Include version check and test for tearoff menu entry

From
Heiko Voigt <hvoigt@hvoigt.net>
Date
Feb 14, 2011, 21:31 UTC
Message-ID
<20110214213148.GB50815@book.hvoigt.net>
In-Reply-To
<878vxilndt.fsf_-_@fox.patthoyts.tk>
Hi,
On Mon, Feb 14, 2011 at 01:03:24PM +0000, Pat Thoyts wrote:
Show 20 quoted lines
> The --all option for git fetch was added in v1.6.6 so ensure we have a usable version before adding
> the menu items.
> Sometimes people use tearoff menus and these offset the entry indices by one.
> 
> Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
> ---
> 
> Heiko Voigt <hvoigt@hvoigt.net> writes:
> >It just came to my mind that I probably should implement a version check
> >of the commandline to ensure that this option is available. Thats why I
> >tagged only this patch with RFC.
> >
> >Cheers Heiko
> 
> The posted patch seems fine except that an error is reported if tearoff
> menus are present. So this patch accommodates tearoff's. I looked up
> when the --all option was added (1.6.6) and skip adding the menu entry
> if we have an older version.
> 
> Seems to do the right thing.

Works and looks good to me as well. Did not know about tearoff menues how do you get those?

Cheers Heiko

P.S.: I discovered a whitespace issue in line 258 which came from my patch. Could you correct that?

Previous: Pat ThoytsNext: Pat Thoyts
Message 7 of 17 in “git-gui: fix deleting item from all_remotes variable”
  1. 1/2 git-gui: fix deleting item from all_remotes variableHeiko Voigt, Feb 12, 2011
  2. Pat ThoytsFeb 13, 2011
  3. Heiko VoigtFeb 13, 2011
  4. 1/2 git-gui: refactor remote submenu creation into subroutineHeiko Voigt, Feb 13, 2011
  5. 2/2 git-gui: teach fetch/prune menu to do it for all remotesHeiko Voigt, Feb 13, 2011
  6. git-gui: Include version check and test for tearoff menu entryPat Thoyts, Feb 14, 2011
  7. Heiko VoigtFeb 14, 2011
  8. Pat ThoytsFeb 15, 2011
  9. Heiko VoigtFeb 17, 2011
  10. Jens LehmannFeb 22, 2011
  11. 1/2 git-gui: fetch/prune all entry only for more than one entryHeiko Voigt, Feb 22, 2011
  12. Pat ThoytsFeb 24, 2011
  13. 2/2 git-gui: fetch/prune all entry appears lastHeiko Voigt, Feb 22, 2011
  14. Jens LehmannFeb 23, 2011
  15. Pat ThoytsFeb 24, 2011
  16. Heiko VoigtFeb 13, 2011
  17. Heiko VoigtFeb 13, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.